Expose os and arch param for BaseRunnerGroup #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The config params loaded in [settings](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/settings.py#L33) maps to the [BaseRunnerGroup](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/runner_group.py#L32) . - Added `os` and `arch` params to the BaseRunnerGroup in order to configure them through the config yaml. - This is required for filtering the [download_url](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/runner_group.py#L130)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 86.54% 86.77% +0.22%
==========================================
Files 34 34
Lines 1420 1422 +2
==========================================
+ Hits 1229 1234 +5
+ Misses 191 188 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tcarmet
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osandarchparams to the BaseRunnerGroup in order to configure them through the config yaml.